Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Fleet introduction #1546

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Review Fleet introduction #1546

merged 1 commit into from
Nov 25, 2024
+40 −16

Conversation

moio
Copy link
Contributor

@moio moio commented Nov 6, 2024

Description

The current introduction paragraph to Fleet has multiple issues:

  • it claims outdated scalability claims that we have removed from websites and other documentation years ago (rancher/fleet-docs@fc7bd30)
  • it points to Fleet standalone installation instructions, which is misleading given this guide is all about integration in Rancher
  • it reiterates that Fleet is a standalone project. While true from a source code perspective, our current direction when it comes to users is to present it as an integrated functionality in Rancher

I removed the paragraph altogether and replaced it with the current introduction we give in current official fleet docs.

@moio
Copy link
Contributor Author

moio commented Nov 6, 2024

CC @pdaigle for PM awareness

CC @gboriso, @rbreddy for Support awareness

@moio moio changed the title Add disconnected cluster best practices guide Review Fleet introduction Nov 6, 2024
@moio
Use up-to-date Fleet intro
4174a58 
Signed-off-by: Silvio Moioli <[email protected]>
@moio
Copy link
Contributor Author

moio commented Nov 6, 2024

CC @manno for technical leadership awareness

@moio moio requested a review from btat November 14, 2024 07:36
@btat btat merged commit 57d019e into rancher:main Nov 25, 2024
1 check passed
@moio moio deleted the fleet_intro branch November 25, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btat btat btat approved these changes

@LucasSaintarbor LucasSaintarbor Awaiting requested review from LucasSaintarbor LucasSaintarbor is a code owner

@sunilarjun sunilarjun Awaiting requested review from sunilarjun sunilarjun is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moio @btat